Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not let low-level expections leak through the API #11

Open
dlyash opened this issue Jun 11, 2015 · 0 comments
Open

Do not let low-level expections leak through the API #11

dlyash opened this issue Jun 11, 2015 · 0 comments
Labels
enhancement

Comments

@dlyash
Copy link
Contributor

dlyash commented Jun 11, 2015

Currently, any RestMarketoClient's method may throw javax.ws.rs.ProcessingException or javax.ws.rs.WebApplicationException. Not only it exposes implementation details but also forces clients to deal with it on their own.

Proposed:

  • Catch ProcessingException inside SDK and throw MarketoApiException instead
  • the same for javax.ws.rs.WebApplicationException
@dlyash dlyash changed the title Do not let ProcessingException leak through the API Do not let low-level expections leak through the API Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dlyash