Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor in decimal as the property of the contract #401

Open
SmartLayer opened this issue Nov 6, 2020 · 0 comments
Open

factor in decimal as the property of the contract #401

SmartLayer opened this issue Nov 6, 2020 · 0 comments
Assignees

Comments

@SmartLayer
Copy link

SmartLayer commented Nov 6, 2020

The contract has to have the decimal property applied to many but not all attributes, instead of them being specified as as="e16"

Example scenario where as wouldn't solve the problem:

<ts:attribute name="pairedTokenAllowance">
    <ts:type>
        <ts:syntax>1.3.6.1.4.1.1466.115.121.1.27</ts:syntax>
    </ts:type>
    <ts:origins>
        <ethereum:call function="allowance" contract="pair">
            <ts:data>
                <ts:address ref="ownerAddress"></ts:address>
                <ts:address ref="CoFiXRouter"></ts:address>
            </ts:data>
        </ethereum:call>
    </ts:origins>
</ts:attribute>

It's also important to be able to specify decimal in TS instead of through reference to the contract decimals public method since many contracts don't implement it, such as CoFiXPair.sol

@SmartLayer SmartLayer self-assigned this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant