Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approved to move and Gave approval to move activities title are truncated #389

Open
hboon opened this issue Sep 18, 2020 · 2 comments
Open
Assignees

Comments

@hboon
Copy link
Member

hboon commented Sep 18, 2020

These 2 activities seem to frequently be associated with a large value that the following text is often (always?) truncated:

Approved to move <symbol>

and:

Gave approval to move <symbol>

Maybe truncate middle or hide the value completely for these 2 activities?

@SmartLayer
Copy link

SmartLayer commented Sep 20, 2020

I checked MetaMask and in their Activity, they simply hid the amount that is approved.

screenshot

Is it urgent? The reason I ask is that it seems all dapps today approved a maximum possible number (transaction generated by Uniswap). So I may update the code to show "Unlimited" instead. That requires a bit of JS detective work.

screenshot

@hboon
Copy link
Member Author

hboon commented Sep 21, 2020

Not urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants