Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Hanging process in SWE-Bench reproducing script #160

Closed
kevin-support-bot bot opened this issue Jan 1, 2025 · 7 comments
Closed

[Bug]: Hanging process in SWE-Bench reproducing script #160

kevin-support-bot bot opened this issue Jan 1, 2025 · 7 comments

Comments

@kevin-support-bot
Copy link

All-Hands-AI#5952 Issue


@fishmingyu fake_user_response_fn is used here. Could you debug it's value?

@fishmingyu
Copy link

Sorry, the issue is about how to avoid the state: AgentState.AWAITING_USER_INPUT. Do you know how to control it when reproducing swebench? It is important to have a non-interaction process.

@SmartManoj
Copy link
Owner

SmartManoj commented Jan 1, 2025

Adding an instruction here may solve this. But that's not considered as reproducing.


If the LLM gives just a message, the agent will provide this default value in eval.

You could modify this line. Here only, it asks for the user input.

@SmartManoj
Copy link
Owner

SmartManoj commented Jan 1, 2025

Regression from All-Hands-AI#5868. Could you test on a2e9e20?

MRE

@fishmingyu
Copy link

Hi @SmartManoj , thank you so much for providing these hints. I actually tested on branch 2ec2f25, the newest one. Thus I think the problem is same for a2e9e20. I will revise your recommended line then.

@SmartManoj
Copy link
Owner

SmartManoj commented Jan 1, 2025

You may see the error.

/usr/lib/python3.12/concurrent/futures/thread.py:95: RuntimeWarning: coroutine 'run_controller.<locals>.on_event' was never awaited
  del work_item
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

In the latest, the function is not called itself due to the regression.

MRE

tested on a2e9e20 and works perfectly.


@SmartManoj
Copy link
Owner

Here the async keyword is the problem. Now works on the HEAD f3885ca

@fishmingyu
Copy link

Thank you so much, it works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants