Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC 1] Bundle proposal tx #1

Open
5 of 7 tasks
wtfsayo opened this issue Sep 12, 2024 · 9 comments
Open
5 of 7 tasks

[EPIC 1] Bundle proposal tx #1

wtfsayo opened this issue Sep 12, 2024 · 9 comments
Assignees

Comments

@wtfsayo
Copy link
Member

wtfsayo commented Sep 12, 2024

  • Find Bundling Approach
  • Write Bundler SC
  • Deploy to Sepolia & Holesky
  • Create first escrow from UI
  • Handle Native Token ~
  • Deploy to Base, Zora, OP mainnet & testnets
  • Deploy to ETH Mainnet
@benedictvscriticus
Copy link
Member

  • bundler smart contract takes invoice address and uses it as receiver for the proposal
    • Is it possible to predict the deterministic address with the salt?
    • If we can predict the address and use it in a bundled transactions, then we would not need the bundler to create the invoice upfront.
  • Alternate: take the transaction and create a deterministic address

@scottrepreneur
Copy link

Bundle these in the proposal txs instead

@scottrepreneur scottrepreneur changed the title [EPIC 1] Bundler Smart Contract [EPIC 1] Bundle proposal tx Sep 23, 2024
@dan13ram dan13ram self-assigned this Sep 24, 2024
@benedictvscriticus
Copy link
Member

Found a small vulnerability

  • one creates an invoice and the second sends funds to the invoice
  • If the invoice cannot be created deterministically, a malicious actor may substitute the invoice address with their own invoice.
    • In this case, the proposal would fail.
    • Rough UX and small vulnerability.
  • We want to bundle the smart contracts instead.

@benedictvscriticus
Copy link
Member

Are we able to access the execution transaction hash with the creation of the proposal? If so, we can find the address for funding and releasing funds.

@benedictvscriticus
Copy link
Member

Answer to this question is NO.

Are we able to access the execution transaction hash with the creation of the proposal? If so, we can find the address for funding and releasing funds.

@benedictvscriticus
Copy link
Member

Metadata needs to be pinned before adding proposal description and title. As of right now only metadata for milestones can be added to metadata by @wtfsayo.

@benedictvscriticus
Copy link
Member

@wtfsayo will be testing the flow with bundle tx this week on sepolia. Once this everything is tested, we can deploy across networks Nouns Builder supports.

@wtfsayo
Copy link
Member Author

wtfsayo commented Oct 16, 2024

Updated the tasks!!

@benedictvscriticus
Copy link
Member

@dan13ram will hold off from deployment until proposal passed and E2E flow could been tested

wtfsayo pushed a commit that referenced this issue Nov 8, 2024
change button to create instead of submit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants