Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAM Flag #987

Open
Slowpoke101 opened this issue Nov 3, 2016 · 5 comments
Open

RAM Flag #987

Slowpoke101 opened this issue Nov 3, 2016 · 5 comments

Comments

@Slowpoke101
Copy link
Owner

Add a flag to notify players that they need to increase RAM

@progwml6
Copy link
Collaborator

progwml6 commented Nov 3, 2016

this is meant to notify about work to get done.... whoever codes this(if i don't get to it first) please speak to me

@jikuja
Copy link
Collaborator

jikuja commented Nov 4, 2016

What are we talking here here:

  • checking that -Xmx is equals higher than the flag
  • checking total RAM and -Xmx?
  • checking if additional java arguments contains conflicting flag?
  • setting -Xms to new flag and then checking if -Xmx is enough high?

I'm not sure if -Xms should be used at all. Performance gain?

@progwml6
Copy link
Collaborator

progwml6 commented Nov 4, 2016

xms will be covered in #988

this is really meant to ensure that newer high ram packs inform & allow users to increase ram in a dialog if the current value is too low and the system supports a higher ram value

total ram and xmx will need to be checked similar to the existing 32 bit ram maximization code. either we allow people to increase the xmx via a slider(like what's in options, and hooked into that same setting) or we increase it to 512mb above the minimum setting in the xml (if it exists)

if no setting exists in the xml default to current values

if the user's machine doesn't have enough ram warn them that they probably won't be able to play the pack.

we will need to consider if we are going to pop the boxes up again if they don't increase the ram above the threasholds or not in the same pack

@progwml6
Copy link
Collaborator

progwml6 commented Nov 7, 2016

i've added minClientRam to the xml support code in the launcher. Its not in the api yet(in case anybody uses the xml>json stuff on there)

@progwml6
Copy link
Collaborator

progwml6 commented Nov 7, 2016

info on where to look to complete these changes 7965f93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants