Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RTSTRUCT end-capping #178

Open
lassoan opened this issue Jan 28, 2021 · 3 comments
Open

Improve RTSTRUCT end-capping #178

lassoan opened this issue Jan 28, 2021 · 3 comments
Assignees

Comments

@lassoan
Copy link
Member

lassoan commented Jan 28, 2021

  1. End-capping creates nice smooth segments but sometimes it creates unexpected results (see for example Hollowed DICOM RT-structures are not supported #171 (comment)). It should be possible to enable/disable it using a conversion parameter (enabled by default).

  2. End-capping creates incorrectly oriented normals at the bottom of the structure. See for example (phantom-ent dataset - https://downgit.github.io/#/home?url=https://github.com/SlicerRt/SlicerRtData/tree/master/eclipse-8.1.20-phantom-ent/Original) brain segment. It is visible when exported to models:

image

@lassoan
Copy link
Member Author

lassoan commented Jan 28, 2021

@Sunderlandkyl it would be great if you could have a look at this, too. Multiple groups would like to use SlicerRT DICOM importers because it is so good. However, it is not nice that exported models have to be fixed up (e.g., using vtkPolyDataNormals).

Sunderlandkyl added a commit that referenced this issue Jan 28, 2021
Add "End capping" conversion parameter to vtkPlanarContourToClosedSurfaceConversionRule.
1 (default) = close surface by generating end caps.
0 = leave contours open on surface exterior.

Re #178
@Sunderlandkyl
Copy link
Collaborator

Ok. End cap normal direction should now be fixed, and I've added a conversion parameter to enabled/disable end capping (default enabled).

I plan to add these additional improvements to the end capping:

  • Use vtkContourTriangulator to better handle nested contours
  • Add additional conversion parameter to switch between the interpolated end cap and the simple straight end cap.

@lassoan
Copy link
Member Author

lassoan commented Jan 29, 2021

Thanks a lot!

Both planned tasks would be really nice.

Maybe instead of an additional conversion parameter, we could have multiple values for endcapping (0=none, 1=smooth, 2=straight).

Sunderlandkyl added a commit that referenced this issue Jan 29, 2021
By setting the "End capping" parameter, the method used to generate end caps can be changed:
- 0 = leave contours open on surface exterior.
- 1 (default) = close surface by generating smooth end caps.
- 2 = close surface by generating straight end caps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants