-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve RTSTRUCT end-capping #178
Comments
@Sunderlandkyl it would be great if you could have a look at this, too. Multiple groups would like to use SlicerRT DICOM importers because it is so good. However, it is not nice that exported models have to be fixed up (e.g., using vtkPolyDataNormals). |
Add "End capping" conversion parameter to vtkPlanarContourToClosedSurfaceConversionRule. 1 (default) = close surface by generating end caps. 0 = leave contours open on surface exterior. Re #178
Ok. End cap normal direction should now be fixed, and I've added a conversion parameter to enabled/disable end capping (default enabled). I plan to add these additional improvements to the end capping:
|
Thanks a lot! Both planned tasks would be really nice. Maybe instead of an additional conversion parameter, we could have multiple values for endcapping (0=none, 1=smooth, 2=straight). |
By setting the "End capping" parameter, the method used to generate end caps can be changed: - 0 = leave contours open on surface exterior. - 1 (default) = close surface by generating smooth end caps. - 2 = close surface by generating straight end caps.
End-capping creates nice smooth segments but sometimes it creates unexpected results (see for example Hollowed DICOM RT-structures are not supported #171 (comment)). It should be possible to enable/disable it using a conversion parameter (enabled by default).
End-capping creates incorrectly oriented normals at the bottom of the structure. See for example (phantom-ent dataset - https://downgit.github.io/#/home?url=https://github.com/SlicerRt/SlicerRtData/tree/master/eclipse-8.1.20-phantom-ent/Original) brain segment. It is visible when exported to models:
The text was updated successfully, but these errors were encountered: