Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout to organize Dockerfile for multiple distributions #6

Open
jcfr opened this issue May 31, 2016 · 4 comments
Open

Layout to organize Dockerfile for multiple distributions #6

jcfr opened this issue May 31, 2016 · 4 comments

Comments

@jcfr
Copy link
Member

jcfr commented May 31, 2016

Currently the Dockerfile are based on centos5, this is great and should not change.

In addition of these default docker files, I would like store Dockerfile that would allow to easily test the build of Slicer on other distribution, it would be a systematic way of documenting and testing what is already on the Slicer wiki here

I propose the following layout:

<root>
  |- slicer-build-base
  |           |- Dockerfile   # Default: centos5
  |           |
  |           |- Ubuntu-16.04-amd64
  |           |       |- DockerFile
  |           |
  |           |- Debian-8.4.0-amd64
  |                   |- DockerFile
  |
  |- slicer-build-deps
  |           |- Dockerfile   # Default: centos5
  |           |
  |           |- Ubuntu-16.04-amd64
  |           |       |- DockerFile
  |           |
  |           |- Debian-8.4.0-amd64
  |                   |- DockerFile
  |
  |- slicer-build
  |           |- Dockerfile   # Default: centos5
  |           |
  |           |- Ubuntu-16.04
  |           |       |- DockerFile
  |           |
  |           |- Debian-8.4.0-amd64
  |                   |- DockerFile

with the introduction of a new intermediate image stored on commontk/CTKDocker:

<root>
  |- qt-build
  |           |- Dockerfile   # Default: centos5
  |           |
  |           |- Ubuntu-16.04
  |           |       |- DockerFile
  |           |
  |           |- Debian-8.4.0-amd64
  |                   |- DockerFile
@jcfr
Copy link
Member Author

jcfr commented May 31, 2016

Cc: @thewtex @QuadmasterXLII

@jcfr jcfr changed the title Layout to integrate Dockerfile for multiple distributions Layout to organize Dockerfile for multiple distributions May 31, 2016
@jcfr
Copy link
Member Author

jcfr commented May 31, 2016

@thewtex
Copy link
Member

thewtex commented May 31, 2016

@jcfr sounds good.

After first getting the images up, we could consider finding a way to prevent duplicate content in the Dockerfile's. Or, we may find that the complexity is not worth it.

@jcfr
Copy link
Member Author

jcfr commented May 31, 2016

we may find that the complexity is not worth it.

Agreed. This is a concern. It is a balance between complexity and simplicity.

prevent duplicate content

to avoid duplicated content, we could use dockerfile generator ... https://www.npmjs.com/package/dockerfile-generator

Related reads:

I suggest we wait to have few of the Dockerfile before coming with a solution avoiding duplication ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants