Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoChooser::AddAutoRoutine lambda parameter inconsistent between Java and C++ #906

Closed
bhall-ctre opened this issue Oct 31, 2024 · 0 comments · Fixed by #931
Closed

AutoChooser::AddAutoRoutine lambda parameter inconsistent between Java and C++ #906

bhall-ctre opened this issue Oct 31, 2024 · 0 comments · Fixed by #931
Labels
component: choreolib-cpp component: choreolib-java type: bug Something isn't working
Milestone
2025-beta-7

Comments

@bhall-ctre
Copy link

bhall-ctre commented Oct 31, 2024 •
edited
Loading

The Java version takes a function that accepts an AutoFactory and returns an AutoRoutine (which does not completely match documentation), whereas the C++ version takes a function that accepts nothing and returns a CommandPtr (which also does not completely match documentation).
@calcmogul calcmogul modified the milestones: 2025-beta-7, 2025-beta-5 Nov 11, 2024
calcmogul added a commit to calcmogul/Choreo that referenced this issue Nov 18, 2024
@calcmogul
[choreolib] Remove C++ command support
9a5f9c2 
There's several severe bugs open that we don't have the bandwidth to
fix.

Closes SleipnirGroup#901, SleipnirGroup#906, SleipnirGroup#907, SleipnirGroup#908.
@calcmogul calcmogul mentioned this issue Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: choreolib-cpp component: choreolib-java type: bug Something isn't working
Projects
None yet
Milestone
2025-beta-7
Development

Successfully merging a pull request may close this issue.

[choreolib] Remove C++ command support calcmogul/Choreo
2 participants
@calcmogul @bhall-ctre