Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needless copies related to gradient blocks in residual computation #1

Open
Slaedr opened this issue Nov 20, 2018 · 2 comments
Open

Needless copies related to gradient blocks in residual computation #1

Slaedr opened this issue Nov 20, 2018 · 2 comments
Labels
performance-bug Issues that do not affect correctness of simulations, but only performance

Comments

@Slaedr
Copy link
Owner

Slaedr commented Nov 20, 2018 •
edited
Loading

Fix needless copies in

  • Weighted least-squares reconstruction: final assignment of gradients to output variables
  • viscous flux computation: before passing for conversion to primitve-2
  • MUSCL Van-Albada reconstruction
@Slaedr Slaedr added the performance-bug Issues that do not affect correctness of simulations, but only performance label Nov 20, 2018
@Slaedr
Copy link
Owner Author

Slaedr commented Dec 13, 2018 •
edited
Loading

Removed copies in MUSCL Van-Albada reconstruction in MPI branch.

@Slaedr
Copy link
Owner Author

Slaedr commented Dec 13, 2018

Before passing for conversion for primitive-2 in viscous flux computation, copies are required because Gradblocks are col-major and the function takes row-major arrays for the gradients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance-bug Issues that do not affect correctness of simulations, but only performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Slaedr