Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect fishing documentation #7671

Open
1 task done
Fusezion opened this issue Mar 3, 2025 · 4 comments
Open
1 task done

Incorrect fishing documentation #7671

Fusezion opened this issue Mar 3, 2025 · 4 comments
Labels
documentation Related to Skript's official documentation. good first issue An issue that would be good for a first-time contributor to make a PR for

Comments

@Fusezion
Copy link
Contributor

Fusezion commented Mar 3, 2025

Skript/Server Version

N/A (not loaded)

Bug Description

The documentation examples for the player fish event is incorrect, it says there's fishing states in skript on fishing state of caught entity

Expected Behavior

Correct documentation to be provided to public users

Steps to Reproduce

view docs https://docs.skriptlang.org/docs.html?search=#fishing

Errors or Screenshots

No response

Other

I personally believe it's best to actually implement the incorrect example, this was originally the design and was changed without any way for users to retain previous behavior, the changes not only caused issues for people who want to handle everything in one singular event, but offers no way to retain bukkit behavior in some form.

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@LisooYT
Copy link

LisooYT commented Mar 3, 2025

https://skripthub.net/docs/?id=1043
use this, and tell us which skript version you use and more about it, like sk info, but since skript 2.10 update, the syntax for fishing changed, check out the link
on fish catch:
and the examples seem to be outdated for skriptlang docs

@Efnilite
Copy link
Member

Efnilite commented Mar 3, 2025

  • this was just an old design of the fish pr, this wasn't actually ever implemented.
  • the old bukkit event can still be used with [on] [fishing] (line|rod) cast
  • the current iimplementation is much more english friendly

@Efnilite Efnilite added documentation Related to Skript's official documentation. good first issue An issue that would be good for a first-time contributor to make a PR for labels Mar 3, 2025
@Fusezion
Copy link
Contributor Author

Fusezion commented Mar 3, 2025

  • the old bukkit event can still be used with [on] [fishing] (line|rod) cast

no? The old bukkit event would be called for all states, hence the desire to readd it

@sovdeeth
Copy link
Member

sovdeeth commented Mar 3, 2025

yes i think an on fishing state change would be a good event to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to Skript's official documentation. good first issue An issue that would be good for a first-time contributor to make a PR for
Projects
None yet
Development

No branches or pull requests

4 participants