Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set prefix via english.lang file #7605

Open
1 task done
Hurming opened this issue Feb 11, 2025 · 8 comments
Open
1 task done

Can't set prefix via english.lang file #7605

Hurming opened this issue Feb 11, 2025 · 8 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@Hurming
Copy link

Hurming commented Feb 11, 2025

Skript/Server Version

Skript: 2.10.1
Server: 1.21.4

Bug Description

Prefix problem when i try to change [Skript] prefix to custom prefix and start my server it's not change to the new prefix I set

Expected Behavior

it's should change to new prefix

Steps to Reproduce

plugins/skript/lang/english.lang --> prefix: Hurming |

Errors or Screenshots

No erros

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@ShaneBeee
Copy link
Contributor

Image

looking at the English language file, im assuming you’re following the wrong format.

@TheAbsolutionism
Copy link
Contributor

So it would seem Skript uses the english.lang that's in its resources directory in the plugin/jar rather than the one that users can see and edit. That's my hunch as I changed the english.lang within the server directory to Smurfy and the one within the plugin to SmurfyTest

Image

and as you can see, SmurfyTest is used

@TheAbsolutionism
Copy link
Contributor

TheAbsolutionism commented Feb 11, 2025

Further proved as manually changing the version node within english.lang in the server directory to 2.9.5
The class Language.java should be updating the lang file as the versions dont match, however it does not get updated.

@Hurming
Copy link
Author

Hurming commented Feb 11, 2025

Image looking at the English language file, im assuming you’re following the wrong format.

No I am on the right track

Image

@Pikachu920
Copy link
Member

i think you need to edit default.lang

@Hurming
Copy link
Author

Hurming commented Feb 12, 2025

i think you need to edit default.lang

How?

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Feb 15, 2025
@erenkarakal erenkarakal changed the title English Lang Can't set prefix via english.lang file Feb 18, 2025
@erenkarakal
Copy link
Member

i think you need to edit default.lang

How?

you can open the Skript jar with a zip tool and edit it inside the lang folder

@TheAbsolutionism
Copy link
Contributor

you can open the Skript jar with a zip tool and edit it inside the lang folder

Please don't, the default.lang isn't even what should be getting edited, it would be the english.lang.
Also I highly advise not editing the files within the plugin itself, because it will just be overwritten from the next Skript release.

The bug here is that Skript doesn't use the lang files within the server's directory as it should, and only uses the lang files within its own resources directory from the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

6 participants