Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuration of rsync options #8

Closed
thhermansen opened this issue Feb 17, 2019 · 2 comments
Closed

Add support for configuration of rsync options #8

thhermansen opened this issue Feb 17, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@thhermansen
Copy link
Member

I have set up k8sync for a Ruby project which runs Gard and the syncing of files works fine.

However, most of the time the sync of files does not trigger Guard to rerun the relevant tests. I found a couple of issues which seems related in Guard: guard/guard#794 and guard/listen#350.

The comment guard/guard#794 (comment) and guard/listen#350 (comment) seems relevant which requires us to pass --inplace to rsync.

I suggest we make the args around here

k8sync/lib/Sync.ts

Lines 36 to 43 in 4d34ae5

const rsyncArgs = [
'--recursive',
'--links',
'--executability',
'--times',
'--compress',
'--delete-after',
]

configurable so we can add additional options per sync in the config file.

@thhermansen thhermansen added the enhancement New feature or request label Feb 17, 2019
@thhermansen
Copy link
Member Author

I tested https://github.com/Skalar/k8sync/compare/inplace-flag. It works and makes guard detect changes :)

@thhermansen
Copy link
Member Author

Do we wanna have this option explicit in the config (like it is in the test-branch), or do we want to extend the config so we can pass arbitrary options to syncing lib rsync?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant