Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Exceeding Windows 250 character limit #27

Open
AdamHess opened this issue Dec 12, 2018 · 4 comments
Open

Allow Exceeding Windows 250 character limit #27

AdamHess opened this issue Dec 12, 2018 · 4 comments

Comments

@AdamHess
Copy link

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

Will not work if SerializationFolderPathMaxLength+ 8 + MaxItemNameLengthBeforeTruncation > 250

Desired Behavior

Ability to set even longer lengths or not be artificially restricted and then display error message when exception is thrown due to path length being an issue and to enable long path length on our OS.

Option name ideas:
Rainbow.Sfs.DisablePathLengthChecks or Rainbow.Sfs.AllowUnlimitedPathLength

Please mention your Sitecore version, Rainbow version, and if also using Unicorn, your version of that too.

9.0.2 and 2.01

@cassidydotdk
Copy link
Member

cassidydotdk commented Dec 12, 2018

We've had this feature debated a lot of times, and we continue to re-evaluate it every... 3-4 months or so. The problem is not just Rainbow, it's also the surrounding tooling. Enabling a setting such as this will make it so that you HAVE to deploy to Windows Server 2016 (AND have the same limitation disabled). Then there are concerns around the GIT for Windows client (last checked, it did not support the extended path length), Zip tools and so on.

We are getting to the point where it might be feasible to release this as an option. I plan to look into this in the early new year.

I think there are many shops still that run on Windows Server 2012. What do you use at your place @AdamHess ?

@AdamHess
Copy link
Author

2012 and 2016. They both support long paths you just need to enable them either through group policy or registry key.

It would make more sense to allow developers to shoot themselves in the foot in the first place, just give them a warning when they do.

It wouldn't take much for this, just change this line here:

const int windowsMaxPathLength = 240; // 260 - sundry directory chars, separators, file extension allowance, etc

Alternatively you could make an easier way to override that

@AdamHess
Copy link
Author

I'm not 100% if this would apply but AFAIK you can get windows tooling to exceed the path-length limit: https://stackoverflow.com/a/22575737/1296597

@dmealo
Copy link

dmealo commented Feb 7, 2019

I'm in support of at least having the option to override this via a config switch or value so that there's a way forward for the increasing number of us that are on Windows Server 2016 or even 2012 with the registry/policy suggested above. Especially with a lot of our clients on Azure even lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants