Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Modules using Event Handler Rules #1359

Open
cjgiddings opened this issue Sep 26, 2024 · 2 comments
Open

Multiple Modules using Event Handler Rules #1359

cjgiddings opened this issue Sep 26, 2024 · 2 comments
Assignees
Labels
impact-behaviour-change Nothing to be worried about. Now even better than before!

Comments

@cjgiddings
Copy link

When you have multiple Modules using the Event Handlers with rules set on the Enabled Rule for the script. If any of these rules fail it will stop any other modules from executing.

To test create two modules using event handlers on the save event, log the data but set different rules on when they can execute. You will notice the code does not allow the subsequence module to run if the previous module rule fails.
This is an easy fix to just swap this from a return to a continue so it can continue to process the other modules it has found.

@michaellwest
Copy link
Member

I wonder if we should provide an option to restore the legacy behavior or to only return for the same module.

@michaellwest michaellwest self-assigned this Sep 27, 2024
@michaellwest michaellwest added the impact-behaviour-change Nothing to be worried about. Now even better than before! label Sep 27, 2024
@michaellwest
Copy link
Member

Seems reasonable to keep processing scripts from other modules instead of just bailing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact-behaviour-change Nothing to be worried about. Now even better than before!
Projects
None yet
Development

No branches or pull requests

2 participants