Some external dependencies are treated like they're not external

[yura415]

Environment:

• typescript version: 3.3.3
• dts-generator version: 3.0.0

dts-generator is treating debug import as if it's an internal module. Probably due to recent update in typescript: the name node kind of import statement is Identifier rather than StringLiteral.

Here is the output for resolveModuleImport(params) { console.log(params) }:

{ importedModuleId: 'debug',
  currentModuleId: 'common/debug',
  isDeclaredExternalModule: false }

The debug module is listed as a dependency in package.json. Typings are also installed (@types/debug).

I suggest to add a check for name node kind to be an Identifier or a StringLiteral in declaredExternalModules routine.

[yura415]

I see now. The problem is how declaration files are written.

For example pino.d.ts, debug.d.ts

They don't have a module declaration with string literal. Debug had an Identifier declaring namespace name (probably?). Pino doesn't have its name in declaration file at all.

[yura415]

Explicitly defining modules in --externs or --types wouldn't help resolving them as external either.

Need a fix for that based on dependencies / devDependencies / node_modules ?