Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix having to copy sitkSourceVersionVars.cmake from build to source for sdist #38

Open
blowekamp opened this issue Aug 7, 2017 · 2 comments

Comments

@blowekamp
Copy link
Member

To produce a valid source distribution the following file needs to be copied from a build to the SimpleITK source git submodule:

cp _skbuild/cmake-build/sitk-sb/SimpleITK-build/sitkSourceVersionVars.cmake ./SimpleITK/CMake/

If the file is not copied then the following error message occurs when compiling the sdsit:

    CMake Error at CMake/sitkSourceVersion.cmake:38 (include):
      include could not find load file:
    
        /tmp/pip-bKa1cY-build/SimpleITK/CMake/sitkSourceVersionVars.cmake
    Call Stack (most recent call first):
      Version.cmake:17 (include)
      CMakeLists.txt:25 (include)
    
@jcfr
Copy link
Collaborator

jcfr commented Aug 7, 2017

This could be address by adding an install rule for that file. The destination could be somewhere in the SimpleITK module.

The install rule could be added directly to the SimpleITK project or to SimpleITKPythonPackage.

@blowekamp
Copy link
Member Author

Are you talking about adding an install run to the setup.py? Do you have an example?

A CMake script needs to be written to generate this file on demand and make this information available to Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants