feat: ✨ Add a method to pause all players at once #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujas-m-simformsolutions
requested changes
Dec 5, 2024
| @@ -140,15 +140,16 @@ class AudioPlayer( | |||
| } | |||
|
|
|||
|
|
|||
| fun pause(result: MethodChannel.Result) { | |||
| fun pause(result: MethodChannel.Result, isPauseAllPlayer: Boolean = false) { | |||
There was a problem hiding this comment.
Why do we need this boolean?
ios/Classes/AudioPlayer.swift
Outdated
| @@ -91,10 +91,12 @@ class AudioPlayer: NSObject, AVAudioPlayerDelegate { | |||
| } | |||
|
|
|||
|
|
|||
| func pausePlayer(result: @escaping FlutterResult) { | |||
| func pausePlayer(result: @escaping FlutterResult, isPauseAllPlayer: Bool = false) { | |||
himanshuGandhiSimform
force-pushed
the
feature/325/pause_all_players
branch
from
26deec9 to
ef20485
Compare
jay-simformsolutions
force-pushed
the
feature/325/pause_all_players
branch
from
ef20485 to
ba326d8
Compare
| ```dart | ||
| playerController.pauseAllPlayers(); | ||
| ``` | ||
| There could be any number of players but you can just call this function from any **one** player and it will pause all the players. |
There was a problem hiding this comment.
Just write, this function works similar to stopAllPlayer.
example/lib/main.dart
Outdated
There was a problem hiding this comment.
Remove this changes
Comment on lines
+143
to
+144
| stopListening() | ||
| player?.pause() |
There was a problem hiding this comment.
add try catch
| @@ -129,26 +129,19 @@ class AudioPlayer( | |||
| } | |||
| } | |||
|
|
|||
| fun stop(result: MethodChannel.Result) { | |||
| fun stop() { | |||
| stopListening() | |||
There was a problem hiding this comment.
add try catch
| .forEach((playKey, controller) { | ||
| controller._setPlayerState(PlayerState.stopped); | ||
| }); | ||
| } | ||
| PlatformStreams.instance.playerControllerFactory.clear(); |
There was a problem hiding this comment.
we dont need clear since we aren't releasing player.
pubspec.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| name: audio_waveforms | |||
| description: A Flutter package that allow you to generate waveform while recording audio or from audio file. | |||
| version: 1.2.0 | |||
| version: 1.2.1 | |||
There was a problem hiding this comment.
update to 1.3.0
jay-simformsolutions
force-pushed
the
feature/325/pause_all_players
branch
from
ba326d8 to
e9850d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 325