Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] ssl option for linux side #93

Open
jfmherokiller opened this issue Jan 3, 2025 · 4 comments
Open

[FEATURE_REQUEST] ssl option for linux side #93

jfmherokiller opened this issue Jan 3, 2025 · 4 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 🐧 Linux

Comments

@jfmherokiller
Copy link

jfmherokiller commented Jan 3, 2025

Have you searched for similar requests?

Yes

Is your feature request related to a problem? If so, please describe.

No response

Describe the solution you'd like

add an option to generate the needed openssl certs and configurations for the linux side of the launcher so that addons that desire it or users who wish to make use of ssl dont need to scrub the bat files to figure out how you setup the windows side.

Describe alternatives you've considered

generating the certs myself and configuring the yaml

Additional context

No response

Priority

Medium (Would be very useful)

Is this something you would be keen to implement?

None

@jfmherokiller jfmherokiller added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Jan 3, 2025
@jfmherokiller
Copy link
Author

jfmherokiller commented Jan 3, 2025

for anyone coming behind me the important line to generate your own certs from the batch files is this

"%opensslPath%" req -x509 -newkey rsa:4096 -keyout "%KEY_FILE%" -out "%CERT_FILE%" -days 825 -nodes -subj "/CN=127.0.0.1" %outputRedirection%

and heres the possible bash version (converted using ai)

"${opensslPath}" req -x509 -newkey rsa:4096 -keyout "${KEY_FILE}" -out "${CERT_FILE}" -days 825 -nodes -subj "/CN=127.0.0.1" ${outputRedirection}

@jfmherokiller
Copy link
Author

I am willing to attempt to implement this in a pull request but I am in the process of studying the repo and figuring out the best way that would follow the implied style guide which isnt going to well.

@deffcolony
Copy link
Collaborator

@jfmherokiller The goal is to have the linux version of the launcher in sync with what the windows version of the launcher already offers... which takes a lot of time to update the linux side and since linux has so many distros you have to make sure it can work for all distros (we also speak about macOS and steamdeck)

we plan to make a python version of the sillytavern launcher so we can use one file for all to start the python we would only need a start.bat and start.sh but thats for the far future currently the linux version needs a major update yes

@jfmherokiller
Copy link
Author

jfmherokiller commented Jan 5, 2025

depending on how you wish to play your cards you could go the oobabooga route and have miniconda handle all the dependencies in a possibly localized platform independent manner if they aren't new enough or not available on disk.

That methoid should work for all platforms including the steamdeck and osx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 🐧 Linux
Projects
None yet
Development

No branches or pull requests

2 participants