Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really need asgiref in requirements.txt? #1434

Open
Woseseltops opened this issue Dec 13, 2024 · 3 comments
Open

Do we really need asgiref in requirements.txt? #1434

Woseseltops opened this issue Dec 13, 2024 · 3 comments
Assignees

Comments

@Woseseltops
Copy link
Collaborator

In our deploy.sh script, it automatically reruns pip install -r requirements.txt... but this failed because:

ERROR: Cannot install -r /var/www/repo/requirements.txt (line 2) and typing-extensions==3.10.0.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested typing-extensions==3.10.0.0
    asgiref 3.7.2 depends on typing-extensions>=4; python_version < "3.11"

For now, I fixed this by commenting out asgiref. Can this also be the permanent solution?

@susanodd
Copy link
Collaborator

susanodd commented Dec 16, 2024

I can't find references to either of these in the code.

Maybe some other package that is imported? Or from CNGT scripts?

I see you commented it out on the server. (I did a git stash and git stash apply to pull, so it remains so.)

@susanodd
Copy link
Collaborator

This requirement is commented out on the live server.

Is it possible this is used by Swagger?

@susanodd
Copy link
Collaborator

I found the commit where it was added:

1a32b10

@susanodd susanodd self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants