Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction not applied correctly #10

Closed
LuckPeerlings opened this issue Nov 2, 2024 · 1 comment
Closed

Correction not applied correctly #10

LuckPeerlings opened this issue Nov 2, 2024 · 1 comment

Comments

@LuckPeerlings
Copy link

When applying the calibration, the updated values are sometimes not following the calibration table.

When applying a negative number, the results are off.
When using (small) positive numbers, the values are correct.

Example
Excerpt Log File where a calibration between [-0.2,0.1] rad is given (see table in below MWE). Applied differences are in the order of 2 rad.
Nov 02 21:12:56 2024-11-02T20:12:56.980Z @signalk/calibration navigation.courseOverGroundMagnetic(TestFile.II) 3.648610802127232 => 5.5016394631116565)
Nov 02 21:12:57 2024-11-02T20:12:57.387Z @signalk/calibration navigation.courseOverGroundMagnetic(TestFile.II) 3.653672256959171 => 5.5160544645896685)
Nov 02 21:12:57 2024-11-02T20:12:57.794Z @signalk/calibration navigation.courseOverGroundMagnetic(TestFile.II) 3.6514033289310603 => 5.509592567375386)

Version
SignalK server version 2.11.0
Calibration plugin version 1.3.1

MWE

  1. Create Filestream with the default NMEA 0183 file "/usr/lib/node_modules/signalk-server/samples/plaka.log"
  2. Apply calibration
    bild
  3. Changing the calibration values, such that the differences are all positive (0.1rad) resolves the issue.
tkurki added a commit that referenced this issue Nov 3, 2024
Remove weird period handling code to fix #10. Add a related test case and fix
the existing test case whose assertion made no sense.
@tkurki
Copy link
Member

tkurki commented Nov 3, 2024

See #11. If you remove the period your config should work, but the values won't be capped to [0, Math.PI].

@tkurki tkurki closed this as completed in 6cfc643 Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants