Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighting issue for shuttles #35094

Closed
5 tasks done
Builder-13 opened this issue Jan 31, 2025 · 3 comments · Fixed by #35106 or SierraBay/SierraBay12#3209
Closed
5 tasks done

Lighting issue for shuttles #35094

Builder-13 opened this issue Jan 31, 2025 · 3 comments · Fixed by #35106 or SierraBay/SierraBay12#3209
Labels
Needs Reproduction Bug that needs confirmation it isn't a side effect of another bug. Priority: Low

Comments

@Builder-13
Copy link

Builder-13 commented Jan 31, 2025 •
edited
Loading

Description of issue

Lights can't recalculate properly with the old corners. (#35081)

Upon transition it grabs the lights of the space turf and recalculates them to unnatural values. (#34722)

Difference between expected and actual behaviour

Initial lighting should be preserved for shuttles.

Steps to reproduce

  1. Dock/undock Petrov a couple of times. (works with any shuttle)
  2. Get unnatural lighting on every turf of the shuttle.

Image

Specific information for locating

#35081
#34722

Client version, server revision, & game ID

Client Version: 515
Server Revision: Revision Unknown
Game ID: 861000b7
Current map: SEV Torch

Issue bingo

  • Issue could be reproduced at least once
  • Issue could be reproduced by different players
  • Issue could be reproduced in multiple rounds
  • Issue happened in a recent (less than 7 days ago) round
  • Couldn't find an existing issue about this
@Builder-13
Copy link
Author

Should also break lighting after explosions, but didn't tested it out anew.

@SierraKomodo
Copy link
Contributor

@CrimsonShrike

@SierraKomodo SierraKomodo added Priority: Low Needs Reproduction Bug that needs confirmation it isn't a side effect of another bug. labels Feb 4, 2025
@CrimsonShrike
Copy link
Contributor

ah corners strike back, not too surprised but still

@CrimsonShrike CrimsonShrike mentioned this issue Feb 4, 2025
Merged
@SierraHelper SierraHelper mentioned this issue Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Reproduction Bug that needs confirmation it isn't a side effect of another bug. Priority: Low
Projects
None yet
Milestone
No milestone
3 participants
@SierraKomodo @CrimsonShrike @Builder-13