Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config change advises to re-announce without hostname change #578

Open
timrettop opened this issue Jan 19, 2025 · 0 comments
Open

Config change advises to re-announce without hostname change #578

timrettop opened this issue Jan 19, 2025 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@timrettop
Copy link

Current Behavior

I changed a couple settings and selected Save, the settings did not include a change to the hostname. Selecting Save after any changes (not including the hostname) results in the success message advising to Re-announce.

Image

Expected Behavior

Success message indicating to Re-Announce only displays if an announcement is required.

Steps to Reproduce

No response

Version

v2.0.2

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

ubuntu host - docker container

Anything else?

It looks like the host state shows the lastAnnouncement.address as hostname:port which does not match with the input of hostname only as the form requires.
https://github.com/SiaFoundation/web/blob/d8588a197781d028206ca46a32282d4ab0653061/apps/hostd/components/Config/AnnounceButton.tsx#L33

Maybe it would be good to display the port in the form anyways so users that have to use non-default ports are aware that its configured as they expect.

@timrettop timrettop added the bug Something isn't working label Jan 19, 2025
@n8maninger n8maninger added this to Sia Jan 19, 2025
@n8maninger n8maninger moved this to Todo in Sia Jan 19, 2025
@n8maninger n8maninger added this to the v2.1.0 milestone Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants