Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the appearance of Welcome line #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Prutha-Upadhyay
Copy link

Closed #129

Fixed the appearance of welcome line and make it better!

Screenshot 2024-01-29 223104

Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for swetify ready!

Name Link
🔨 Latest commit 346a95a
🔍 Latest deploy log https://app.netlify.com/sites/swetify/deploys/65c86f70542ff8000813d707
😎 Deploy Preview https://deploy-preview-134--swetify.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShwetKhatri2001
Copy link
Owner

ShwetKhatri2001 commented Feb 1, 2024

Good work. Can you add your CSS to any CSS file instead of putting it in index.html.
Also, if you can make these small fixes then I can assign it as Easy level.

image

  • In the last two sections, Remove extra space and Change the font family of all text to Poppins.
  • The font family should be Poppins everywhere ( all pages ), look for other places where a change might be required.
  • In the sidebar, Popular Categories text should be in a single line.

@ShwetKhatri2001
Copy link
Owner

@Prutha-Upadhyay Will you be able to complete this in the next few days?

@Prutha-Upadhyay
Copy link
Author

I am working on it. Can you clarify that which extra space I have to remove? Between Login and Your Fav music?

@ShwetKhatri
Copy link

I think you've restricted the height of sections to 100vh which is not expected for all sections.

@Prutha-Upadhyay
Copy link
Author

Prutha-Upadhyay commented Feb 6, 2024

Now is that right or not?

Screenshot 2024-02-06 203031

@ShwetKhatri2001
Copy link
Owner

Yes, all good. Can you please push those changes to this branch.

@ShwetKhatri2001
Copy link
Owner

Have a look at this, Below the title Your Favourite Music this kind of list is expected to be shown when the user has some liked songs, it's not coming up in your PR's deploy preview. Look at it on the live version.

image

Try to solve the conflicts, so that it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[style] Changing the font style of Welcome line
3 participants