Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Liked Music Page #125

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Ishaparte
Copy link

Screenshot 2024-01-22 170843
Now the liked music section is redirecting.

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for swetify ready!

Name Link
🔨 Latest commit 768a906
🔍 Latest deploy log https://app.netlify.com/sites/swetify/deploys/65c7b20b23471300079efd51
😎 Deploy Preview https://deploy-preview-125--swetify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ishaparte Ishaparte mentioned this pull request Jan 22, 2024
4 tasks
@ShwetKhatri2001
Copy link
Owner

When I like a song and click Liked Music from there, then it's not redirecting.

@Ishaparte
Copy link
Author

Okay I'll fix.

@Ishaparte
Copy link
Author

Screenshot 2024-01-24 130756
The redirecting is only working with links not with id.

@ShwetKhatri2001
Copy link
Owner

You can try to reload on that URL on click to the link.

@Ishaparte
Copy link
Author

image
actually it is redirecting but the song is still visible. can you plz tell in which js file your changing the css?

@ShwetKhatri2001
Copy link
Owner

On click to the button, you can call these methods - location.replace("https://swetify.netlify.app/#liked") and location.reload(). Instead of #container-linked-list, #liked is better in the current version to be used as id.

@Ishaparte
Copy link
Author

Okay

@ShwetKhatri2001
Copy link
Owner

Please try to fix it soon on the updated code files.

@Ishaparte
Copy link
Author

Sorry actually my laptop got damaged that is why I am not able fix it. Can you plz give me some more time

@ShwetKhatri2001
Copy link
Owner

Sure, take your time. Also, pull the latest code, solve the merge conflicts, and then fix it.

@Ishaparte
Copy link
Author

Thank you!

@ShwetKhatri2001
Copy link
Owner

Will you be able to complete this in the next few days @Ishaparte ?

@Ishaparte
Copy link
Author

Let.s.Play.On.Swetify.-.Google.Chrome.2024-02-07.23-41-27.mp4

is it fine?

@ShwetKhatri2001
Copy link
Owner

Something is wrong as I see in the deploy preview. Please Check.

@Ishaparte
Copy link
Author

Can you plz tell what is wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants