Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createCustomerAddress endpoint incorrect #24

Open
TalalM opened this issue Dec 1, 2015 · 4 comments
Open

createCustomerAddress endpoint incorrect #24

TalalM opened this issue Dec 1, 2015 · 4 comments

Comments

@TalalM
Copy link

TalalM commented Dec 1, 2015

In the library, the endpoint is:
/admin/customers.json

In the doc (https://docs.shopify.com/api/customeraddress#create), it's:
/admin/customers/#{id}/addresses.json

Would it be possible to update the client?
I can submit a pull request if needed.

Thanks,

@cargix1
Copy link
Contributor

cargix1 commented Dec 1, 2015

Sure if you can submit a pull request that would be awesome!

Thanks,

Andy

Andrew Cargill
24/7 Shopify Support - Bugs Resolved Same Day
[email protected] mailto:[email protected]

On 1 Dec 2015, at 09:52, TalalM [email protected] wrote:

In the library, the endpoint is:
/admin/customers.json

In the doc (https://docs.shopify.com/api/customeraddress#create https://docs.shopify.com/api/customeraddress#create), it's:
/admin/customers/#{id}/addresses.json

Would it be possible to update the client?
I can submit a pull request if needed.

Thanks,


Reply to this email directly or view it on GitHub #24.

@TalalM
Copy link
Author

TalalM commented Dec 1, 2015

I submitted it: #25

@TalalM
Copy link
Author

TalalM commented Dec 1, 2015

Are you going to update the package on composer soon to include this change?

@cargix1
Copy link
Contributor

cargix1 commented Dec 1, 2015

If i’m honest i’m a little inexperienced in Tagging / Versioning with git. But i’ll try my best to get my head around things asap for you :)

Andrew Cargill
24/7 Shopify Support - Bugs Resolved Same Day
[email protected] mailto:[email protected]

On 1 Dec 2015, at 10:39, TalalM [email protected] wrote:

Are you going to update the package on composer soon to include this change?


Reply to this email directly or view it on GitHub #24 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants