Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Ruby Version to .ruby-version #287

Closed
wants to merge 2 commits into from

Conversation

jenshenny
Copy link

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR adds the .ruby-version file, and removes all other references to Ruby in this repository, aligning it with the standard.

What should reviewers focus on?

Important

Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

  • .ruby-version file is present with the correct Ruby version defined
  • There is no Ruby version/requirement referenced in the Gemfile (no lines with ruby <some-version>)
  • A Gemfile.lock is built with the defined Ruby version
  • There is no TargetRubyVersion defined in rubocop.yml
  • There is no Ruby argument present in ruby/setup-ruby Github Actions that do not run on a Ruby matrix (no lines with ruby-version: “x.x”)

Please merge this PR if it looks good, this PR will be merged if there isn't any activity after 4 weeks.

@k0kubun
Copy link
Member

k0kubun commented Apr 1, 2024

For yjit-bench, we need to constantly use multiple Ruby versions. Can we avoid locking the Ruby version in this repository? I don't want .ruby-version to inadvertently switch Ruby from master to 3.3.0 when I enter yjit-bench directory, for example.

@jenshenny
Copy link
Author

For yjit-bench, we need to constantly use multiple Ruby versions. Can we avoid locking the Ruby version in this repository? I don't want .ruby-version to inadvertently switch Ruby from master to 3.3.0 when I enter yjit-bench directory, for example.

Ah gotcha, thanks for the context - I think it makes sense not to add a .ruby-version in this case then. For that reason, I'll close this.

@jenshenny jenshenny closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants