Skip to content

Commit a0cfc0c

Browse files
authored
Lobsters: Remove the transaction_retry gem (#350)
This is a long abandoned gem that's incompatible with Ruby 3. I ran into the kwargs error in qertoip/transaction_retry#12 while running the burn-in script. Upstream lobsters removed this gem a year ago: lobsters/lobsters@eb1d5ef Looks like the gem is only used when DB operations fail, which pretty much never happens outside of burn-in runs where the host gets hammered, so hopefully no change to performance properties.
1 parent 1dbbdce commit a0cfc0c

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

benchmarks/lobsters/Gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ gem "mail" # for parsing incoming mail
5555
gem "ruumba" # tests views
5656
gem "sitemap_generator" # for better search engine indexing
5757
gem "svg-graph", require: 'SVG/Graph/TimeSeries' # for charting, note workaround in lib/time_series.rb
58-
gem 'transaction_retry' # mitigate https://github.com/lobsters/lobsters-ansible/issues/39
5958
gem 'rack-attack' # rate-limiting
6059

6160
group :test, :development do

benchmarks/lobsters/Gemfile.lock

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -284,11 +284,6 @@ GEM
284284
svg-graph (2.2.2)
285285
thor (1.3.0)
286286
timeout (0.4.1)
287-
transaction_isolation (1.0.5)
288-
activerecord (>= 3.0.11)
289-
transaction_retry (1.0.3)
290-
activerecord (>= 3.0.11)
291-
transaction_isolation (>= 1.0.2)
292287
ttfunk (1.7.0)
293288
tzinfo (2.0.6)
294289
concurrent-ruby (~> 1.0)
@@ -355,7 +350,6 @@ DEPENDENCIES
355350
sqlite3
356351
stackprof
357352
svg-graph
358-
transaction_retry
359353
vcr
360354
webmock
361355

0 commit comments

Comments
 (0)