Skip to content

Commit

Permalink
Lobsters: Remove the transaction_retry gem (#350)
Browse files Browse the repository at this point in the history
This is a long abandoned gem that's incompatible with Ruby 3. I ran
into the kwargs error in qertoip/transaction_retry#12
while running the burn-in script.

Upstream lobsters removed this gem a year ago: lobsters/lobsters@eb1d5ef

Looks like the gem is only used when DB operations fail, which pretty much
never happens outside of burn-in runs where the host gets hammered, so
hopefully no change to performance properties.
  • Loading branch information
XrXr authored Dec 4, 2024
1 parent 1dbbdce commit a0cfc0c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion benchmarks/lobsters/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ gem "mail" # for parsing incoming mail
gem "ruumba" # tests views
gem "sitemap_generator" # for better search engine indexing
gem "svg-graph", require: 'SVG/Graph/TimeSeries' # for charting, note workaround in lib/time_series.rb
gem 'transaction_retry' # mitigate https://github.com/lobsters/lobsters-ansible/issues/39
gem 'rack-attack' # rate-limiting

group :test, :development do
Expand Down
6 changes: 0 additions & 6 deletions benchmarks/lobsters/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -284,11 +284,6 @@ GEM
svg-graph (2.2.2)
thor (1.3.0)
timeout (0.4.1)
transaction_isolation (1.0.5)
activerecord (>= 3.0.11)
transaction_retry (1.0.3)
activerecord (>= 3.0.11)
transaction_isolation (>= 1.0.2)
ttfunk (1.7.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
Expand Down Expand Up @@ -355,7 +350,6 @@ DEPENDENCIES
sqlite3
stackprof
svg-graph
transaction_retry
vcr
webmock

Expand Down

0 comments on commit a0cfc0c

Please sign in to comment.