Skip to content

Commit 12e933b

Browse files
committed
Fix linting errors
Removes extra white space in parameters in session_test.py and changes conditional formatting in shopify/session.py.
1 parent adaf770 commit 12e933b

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

shopify/session.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,12 @@ def __init__(self, shop_url, version=None, token=None, access_scopes=None):
5454
return
5555

5656
def create_permission_url(self, redirect_uri, scope=None, state=None):
57-
query_params = dict(client_id=self.api_key, redirect_uri=redirect_uri)
57+
query_params = {"client_id": self.api_key, "redirect_uri": redirect_uri}
5858
# `scope` should be omitted if provided by app's TOML
59-
if scope: query_params["scope"] = ",".join(scope)
60-
if state: query_params["state"] = state
59+
if scope:
60+
query_params["scope"] = ",".join(scope)
61+
if state:
62+
query_params["state"] = state
6163
return "https://%s/admin/oauth/authorize?%s" % (self.url, urllib.parse.urlencode(query_params))
6264

6365
def request_token(self, params):

test/session_test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def test_create_permission_url_returns_correct_url_with_redirect_uri_and_single_
148148
shopify.Session.setup(api_key="My_test_key", secret="My test secret")
149149
session = shopify.Session("http://localhost.myshopify.com", "unstable")
150150
scope = ["write_customers"]
151-
permission_url = session.create_permission_url( "my_redirect_uri.com", scope=scope, state="mystate")
151+
permission_url = session.create_permission_url("my_redirect_uri.com", scope=scope, state="mystate")
152152
self.assertEqual(
153153
"https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&redirect_uri=my_redirect_uri.com&scope=write_customers&state=mystate",
154154
self.normalize_url(permission_url),

0 commit comments

Comments
 (0)