-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script Tags not working inside the Shopify iframe but on Localhost #364
Comments
also tried already this inside my |
I can confirm this. Doesn't work with any external script I tested |
Same issue here, Any Chat or any webwidget is not loading inside shopify admin. |
Any widget not working in my Shopify app? |
I think that almost chat widget using the iframe to load their chat box so shopify app using the iframe to load app inside admin panel while iframe can't load inside other iframe. That's invalid HTML structure |
Also reported here |
@lizkenyon so how to fix this issue? |
Hi folks 👋 Thank you to everyone who has flagged this with us. This is something that we will be looking into. |
yeah same issue we're facing |
same issue i'm facing here as well |
I can fix this issue by load directly content of widget external url |
Hi folks! We have identified the issue. It looks like when the scripts are added they are executing, but the elements these chat scripts are adding are being overwritten. The good news is we have a fix for this already that is waiting for release. We are planning on getting this rolled out in the coming weeks. |
@lizkenyon Any news on this? |
We hope to start rolling this out next week. |
Hi folks 👋 We have a released a change with App Bridge that should allow scripts that update the DOM, (like adding iframes for chat widgets) to work. Please test out adding your scripts and see if they now work. 🙂 |
Thanks @lizkenyon Works like charm |
@lizkenyon which is the latest version? |
It should be working automatically. You will not need to upgrade any package. |
@shopify/shopify-app-remix
version: 1.3.0Expected behavior
script tags should work inside the iframe in the
app/root.jsx
Actual behavior
if you place
<script src="//code.tidio.co/c9w65wqt13hznshrcyl9ajlufdctdgxv.js" async={true} />
under<Scripts />
inside theapp/root.jsx
the script will be loaded, but wont be executed. On the localhost URL from the Shopify app, everything works as expected.Steps to reproduce the problem
app/root.jsx
<script src="//code.tidio.co/c9w65wqt13hznshrcyl9ajlufdctdgxv.js" async={true} />
under<Scripts />
npm run dev
Tested this with a fresh template
The text was updated successfully, but these errors were encountered: