Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to SessionStorage adapter guide #1298

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix link to SessionStorage adapter guide #1298

merged 1 commit into from
Oct 6, 2023

Conversation

nhymxu
Copy link
Contributor

@nhymxu nhymxu commented Oct 6, 2023

WHY are these changes introduced?

shopify-api-js repository restructure folder. Old link not work anymore.

WHAT is this pull request doing?

Change link in README.md

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
  • I have made changes to the README.md file and other related documentation, if applicable

@nhymxu nhymxu requested a review from a team as a code owner October 6, 2023 07:49
@nhymxu
Copy link
Contributor Author

nhymxu commented Oct 6, 2023

I have signed the CLA!

paulomarg
paulomarg approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much appreciated!

@paulomarg paulomarg merged commit 55dbc18 into Shopify:main Oct 6, 2023
6 checks passed
@nhymxu nhymxu deleted the patch-1 branch October 6, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhymxu @paulomarg