Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added calendar view and might have fixed the cli issue. #1281

Closed

Conversation

ShyGuy76
Copy link

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
  • I have made changes to the README.md file and other related documentation, if applicable

@ShyGuy76 ShyGuy76 requested a review from a team as a code owner June 17, 2023 03:11
@sle-c
Copy link

sle-c commented Feb 14, 2024

Hi @ShyGuy76,

Thank you for your contribution. This PR added a react-calendar dependency to the template which will apply to everyone using this template. While react-calendar is a good library, I don't think that everyone needs it. It's best to use the Shopify CLI to create a new Shopify app (documentation). It'll use this template and you can add react-calendar there as a dependency for your app.

Therefore, I'll close this PR as it's not applicable.

@sle-c sle-c closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants