Fix Remix redirect on bounce

[btomaj]

WHY are these changes introduced?

Remix v2 changed some instances of ErrorResponse to ErrorResponseImpl, breaking const { redirect } = authenticate.admin(request); redirects.

WHAT is this pull request doing?

This change allows redirects to work on both ErrorResponse and ErrorResponseImpl.

Type of change

• Patch: Bug (non-breaking change which fixes an issue)
• Minor: New feature (non-breaking change which adds functionality)
• Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
• I have added/updated tests for this change
• I have documented new APIs/updated the documentation for modified APIs (for public APIs)

[btomaj]

@byrichardpowell FYI

[paulomarg]

This seems good to me! Could you please run yarn changeset to add a changeset so we can merge it? This should just be a patch change, and I'd recommend this message:

Fixed the errorBoundary to work with new cases in Remix v2.

[btomaj]

@paulomarg I asked the Remix team about the difference between ErrorResponse and ErrorResponseImpl, and I was told that ErrorResponse is intended for stdout whereas ErrorResponseImpl is internal (meaning not for stdout). I'm not familiar enough with the inner workings of this codebase, so before we merge this in, I wanted to ask if this change from the Remix team requires a bigger change to error handling?

[btomaj]

Added changeset and tests. If I have understood the code correctly, I believe ErrorResponse should be removed unless kept for backward compatibility with earlier versions of Remix, but I will leave that up to you.

[paulomarg]

@paulomarg I asked the Remix team about the difference between ErrorResponse and ErrorResponseImpl, and I was told that ErrorResponse is intended for stdout whereas ErrorResponseImpl is internal (meaning not for stdout). I'm not familiar enough with the inner workings of this codebase, so before we merge this in, I wanted to ask if this change from the Remix team requires a bigger change to error handling?

Thanks for chasing it down. As far as this codebase goes, this is the only place where we do this. We're trying to find a better way to handle the headers in these cases, so hopefully this code will be replaced by a "proper" check in the future.

Let's also leave the previous implementation around, as you said it helps with compatibility and shouldn't cause any problems in v2 if ErrorResponse never reaches this code.