diff --git a/.changeset/dirty-starfishes-accept.md b/.changeset/dirty-starfishes-accept.md new file mode 100644 index 0000000000..c7b5848bd5 --- /dev/null +++ b/.changeset/dirty-starfishes-accept.md @@ -0,0 +1,5 @@ +--- +'@shopify/shopify-app-remix': patch +--- + +Minor refactor in login.ts to use new URL util method from shopify-api-js diff --git a/packages/shopify-app-remix/src/server/authenticate/login/login.ts b/packages/shopify-app-remix/src/server/authenticate/login/login.ts index 0b1e1355e6..50fb88e059 100644 --- a/packages/shopify-app-remix/src/server/authenticate/login/login.ts +++ b/packages/shopify-app-remix/src/server/authenticate/login/login.ts @@ -37,8 +37,8 @@ export function loginFactory(params: BasicParams) { const authPath = `${config.appUrl}${config.auth.path}?shop=${sanitizedShop}`; - const storeName = sanitizedShop.split('.')[0]; - const installPath = `https://admin.shopify.com/store/${storeName}/oauth/install?client_id=${config.apiKey}`; + const adminPath = api.utils.legacyUrlToShopAdminUrl(sanitizedShop); + const installPath = `https://${adminPath}/oauth/install?client_id=${config.apiKey}`; const shouldInstall = config.isEmbeddedApp && config.future.unstable_newEmbeddedAuthStrategy;