Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Scopes constructor handle null parameter #299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix] Scopes constructor handle null parameter #299

wants to merge 2 commits into from
+2 −1

Conversation

sarim
Copy link

@sarim sarim commented Sep 26, 2023 •
edited
Loading

WHY are these changes introduced?

Fixes #290

WHAT is this pull request doing?

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@sarim sarim marked this pull request as ready for review September 26, 2023 22:22
@sarim
Copy link
Author

sarim commented Sep 26, 2023

I have signed the CLA!

@sarim sarim mentioned this pull request Jul 31, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constructor of Shopify\Auth\Scopes can't handle null
1 participant
@sarim