Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed value of sessionExpiration to 0 instead of null #293

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

changed value of sessionExpiration to 0 instead of null #293

wants to merge 3 commits into from

Conversation

da-mask
Copy link

@da-mask da-mask commented Jul 25, 2023

WHY are these changes introduced?

Fixes #291

WHAT is this pull request doing?

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@da-mask
Copy link
Author

da-mask commented Sep 14, 2023

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setcookie() is passed a null instead of 0/[] during OAuth Callback.
1 participant
@da-mask