From b5427bd6be9c188b6dc787a2f8a7436058f485ba Mon Sep 17 00:00:00 2001 From: Kyle Durand Date: Wed, 10 Apr 2024 13:19:50 -0400 Subject: [PATCH] [Picker] Fix activator type (#11875) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### WHY are these changes introduced? Fixes #0000 ### WHAT is this pull request doing? ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --- .../src/components/Picker/components/Activator/Activator.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/polaris-react/src/components/Picker/components/Activator/Activator.tsx b/polaris-react/src/components/Picker/components/Activator/Activator.tsx index ecafab7cd83..f5232232a80 100644 --- a/polaris-react/src/components/Picker/components/Activator/Activator.tsx +++ b/polaris-react/src/components/Picker/components/Activator/Activator.tsx @@ -24,6 +24,7 @@ export const Activator = forwardRef( disabled={disabled} onClick={onClick} className={classNames(styles.Activator, disabled && styles.disabled)} + type="button" > {label && (