-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
❓[Question] React 18 support? #70
Comments
We had the same problem |
Hey @bithaolee, how did you get it solved? Did you manually upgrade refs on this project? I'm working on it here: https://github.com/pnmcosta/discount-app-components-v11 but I have very limitted FE experience and am haven't progressed with the jest update. Happy to take contributions and move it forward quicker. |
The problem hasn't been solved yet, so my solution now is to rewrite the components myself |
Same here then :D have a look at my fork, I already have a head start there if you'd like. Probably gonna privately push it to a repository to use on my app without the Jest tests updated, I'll let you know how I get on with that. |
BTW separate question, do you use https://shopify.dev/docs/api/discounts/components/countries-and-rates-card by any chance? Do you have any issues with it? Getting an odd one with the Am hoping polaris upgrade will sort it out. |
FYI |
@pnmcosta I believe this has been resolved now, if there are any future issues please let us know! |
Polaris is now
^18.0.0
see this.This package is preventing me from updating my app, is this planned to be updated too?
Thank you
The text was updated successfully, but these errors were encountered: