Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❓[Question] React 18 support? #70

Closed
pnmcosta opened this issue Jun 9, 2023 · 7 comments
Closed

❓[Question] React 18 support? #70

pnmcosta opened this issue Jun 9, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@pnmcosta
Copy link

pnmcosta commented Jun 9, 2023

Polaris is now ^18.0.0 see this.

This package is preventing me from updating my app, is this planned to be updated too?

Thank you

@pnmcosta pnmcosta added the bug Something isn't working label Jun 9, 2023
@pnmcosta pnmcosta changed the title 🐛[Question] React 18 support? ❓[Question] React 18 support? Jun 9, 2023
@bithaolee
Copy link

We had the same problem

@pnmcosta
Copy link
Author

pnmcosta commented Jul 7, 2023

Hey @bithaolee, how did you get it solved? Did you manually upgrade refs on this project?

I'm working on it here: https://github.com/pnmcosta/discount-app-components-v11 but I have very limitted FE experience and am haven't progressed with the jest update.

Happy to take contributions and move it forward quicker.

@bithaolee
Copy link

Hey @bithaolee, how did you get it solved? Did you manually upgrade refs on this project?

I'm working on it here: https://github.com/pnmcosta/discount-app-components-v11 but I have very limitted FE experience and am haven't progressed with the jest update.

Happy to take contributions and move it forward quicker.

The problem hasn't been solved yet, so my solution now is to rewrite the components myself

@pnmcosta
Copy link
Author

Same here then :D have a look at my fork, I already have a head start there if you'd like.

Probably gonna privately push it to a repository to use on my app without the Jest tests updated, I'll let you know how I get on with that.

@pnmcosta
Copy link
Author

pnmcosta commented Jul 10, 2023

BTW separate question, do you use https://shopify.dev/docs/api/discounts/components/countries-and-rates-card by any chance? Do you have any issues with it?

Getting an odd one with the unstable_Picker, it doesn't perform search properly and gets stuck on loading, the items are in expected format for it and renders properly, but searching is broken completely.

Am hoping polaris upgrade will sort it out.

@pnmcosta
Copy link
Author

FYI npm i @shopify/discount-app-components@pnmcosta/discount-app-components-v11 seems to be working fine for me, but I had to change the build-verify scripts to accommodate my build runners.

@mathiusj
Copy link
Contributor

mathiusj commented Aug 4, 2023

@pnmcosta I believe this has been resolved now, if there are any future issues please let us know!

@mathiusj mathiusj closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants