Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[Bug] Export DiscountsI18nProvider or have Appprovider accept currency or i18n manager #223

Open
vincaslt opened this issue Oct 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vincaslt
Copy link

Issue summary

AppProvider creates i18n context, but it doesn't allow passing currency or the default manager. Best would be to export DiscountsI18nProvider and let people use that, because if they already use the AppProvider from i18n package, discount provider interferes and resets the manager.

Expected behavior

Actual behavior

Steps to reproduce the problem

  1. First step
  2. Second step

Reduced test case

The best way to get your bug fixed is to provide a reduced test case. This CodeSandbox template is a great starting point.

Specifications

  • Are you using the React components? (Y/N):
  • discount-app-components version number:
  • Browser:
  • Device:
  • Operating System:

Or run npx envinfo --system --binaries --browsers --npmPackages react,react-dom,@shopify/discount-app-components to provide specifications on your environment including version numbers, browser, device, and operating system.

Paste the results here:

@vincaslt vincaslt added the bug Something isn't working label Oct 20, 2024
@vincaslt vincaslt changed the title 🐛[Bug] 🐛[Bug] Export DiscountsI18nProvider or have Appprovider accept currency or i18n manager Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant