Remove dependency on App Bridge React and update navigation patterns and components #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
Fixes: #196
Breaking change - major version release
This PR removes dependency on App Bridge React. In App Bridge React V4+ the utilities for navigation and opening modals are no longer needed. The preferred way is to leverage App Bridge React methods within you app.
Consequences of this change:
Reviewers’ hat-rack 🎩
To tophat this change you'll need to do the following:
Testing in app context:
On your local machine:
shopify app init --template https://github.com/Shopify/function-examples/sample-apps/discounts\#update-discounts-app --package-manager yarn
yalc publish --private
yalc add @shopify/discount-app-components
yarn
to install dependenciesyarn dev
to test your app out on your storeTesting storybook
yarn && yarn storybook
Before requesting reviews
Before you deploy