Fixing settings issue ValveSoftware#52

Author: zite

Providers/UserProjectSettings.cpp

@@ -391,17 +391,19 @@ SetUserDefinedSettings( UserDefinedSettings settings )
 
 	if ( settings.editorAppKey && strlen( settings.editorAppKey ) > 1 )
 	{
-		char *editorAppKey = new char[ strlen( settings.editorAppKey + 1 ) ];
-		strcpy_s( editorAppKey, strlen( settings.editorAppKey ) + 1, settings.editorAppKey );
+		size_t strLen = strlen( settings.editorAppKey ) + 1;
+		char *editorAppKey = new char[ strLen ];
+		strcpy_s( editorAppKey, strLen, settings.editorAppKey );
 		s_UserDefinedSettings.editorAppKey = editorAppKey;
 	}
 
 	if ( settings.actionManifestPath && strlen( settings.actionManifestPath ) > 1 )
 	{
 		if ( UserProjectSettings::FileExists( std::string( settings.actionManifestPath ) ) )
 		{
-			char *actionManifestPath = new char[ strlen( settings.actionManifestPath + 1 ) ];
-			strcpy_s( actionManifestPath, strlen( settings.actionManifestPath ) + 1, settings.actionManifestPath );
+			size_t strLen = strlen( settings.actionManifestPath ) + 1;
+			char *actionManifestPath = new char[ strLen ];
+			strcpy_s( actionManifestPath, strLen, settings.actionManifestPath );
 			s_UserDefinedSettings.actionManifestPath = actionManifestPath;
 		}
 		else
@@ -422,8 +424,9 @@ SetUserDefinedSettings( UserDefinedSettings settings )
 
 	if ( settings.applicationName && strlen( settings.applicationName ) > 1 )
 	{
-		char *appName = new char[strlen( settings.applicationName + 1 )];
-		strcpy_s( appName, strlen( settings.applicationName ) + 1, settings.applicationName );
+		size_t strLen = strlen( settings.applicationName ) + 1;
+		char *appName = new char[ strLen ];
+		strcpy_s( appName, strLen, settings.applicationName );
 		s_UserDefinedSettings.applicationName = appName;
 	}