Skip to content

Enable "proper" PR flow when there is a second contributor #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AFulgens opened this issue Mar 6, 2024 · 0 comments
Open

Enable "proper" PR flow when there is a second contributor #13

AFulgens opened this issue Mar 6, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@AFulgens
Copy link
Contributor

AFulgens commented Mar 6, 2024

Context

PR flow with a pipeline after approval is not feasable with one contributor, because you cannot approve your own PRs [1].

Up until then YOLO, I guess.

To do

When there is a second contributor to the project, consider the following:

  • add trigger workflow_call: to main.yml
  • add pr-reviewed.yml:
name: PR approved
on:
  pull_request_review:
    types:
      - submitted

jobs:
  pr-approved:
    if: github.event.review.state == 'APPROVED'
    name: PR has been reviewed and approved, run main pipeline before merge
    uses: ./.github/workflows/main.yml
  • enable mandatory review for PRs.

[1] https://github.com/orgs/community/discussions/6292

@AFulgens AFulgens added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant