Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing of curriculum metrics to CSV #9

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

will-hou
Copy link
Contributor

Resolves #8

Also matches the formatting of the metrics file exported by curricular analytics more closely:

  • Complexity displayed to one decimal place
  • Delay factor displayed to one decimal place
  • Course credit hours displayed as a whole integer

@will-hou
Copy link
Contributor Author

Testing with the public VCU Public Computer Engineering curriculum

Left is file with metrics downloaded from Curricular Analytics. Right is file without metrics downloaded from Curricular analytics and processed with CurricularAnalytics.py

Only differences are the ordering of pre-reqs but I don't believe that is important (also out of scope for this PR)

image

@SheepTester
Copy link
Member

I'm not sure if we should match Curricular Analytics exactly since unit counts at some universities aren't necessarily an integer. For example, UCSD's language classes are 2.5 units

@will-hou
Copy link
Contributor Author

I'm not sure if we should match Curricular Analytics exactly since unit counts at some universities aren't necessarily an integer. For example, UCSD's language classes are 2.5 units

Ah didn't know that. I removed that change

@will-hou
Copy link
Contributor Author

@SheepTester Are there any other items you want me to address before this can get merged? Thanks!

@SheepTester SheepTester merged commit 135e8ce into SheepTester-forks:main Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write_csv fails to create curriculum csv file with metrics
2 participants