Breaking change in Lucene 4.8.0-beta00017 requires new Build/Release of Examine v4 (beta)

[jemayn]

Heya!

We are using Examine v4.0.0-beta-1 on a number of Umbraco 13 sites for facetting.
With the latest release they bumped the Lucene.Net.Replicator version due to a security issue in the previous one. Along with the security issue they also apparently have a breaking change which makes searching throw errors.

This is the PR to Umbraco with the version update: umbraco/Umbraco-CMS#17415

I think this is the issue with the change: apache/lucenenet#408

[Shazwazza]

So we just need to rebuild the Examine beta release against the new Lucene beta and ship another package right?

[jemayn]

I don't think it's quite that simple, I had a quick look and it's a bit more involved than simply bumping the package version. There are a few locations that use the now removed SnapshotDirectoryTaxonomyWriter:

I had a quick look to see if it was a simple renaming, but they changed it into this SnapshotDirectoryTaxonomyIndexWriterFactory :
https://github.com/apache/lucenenet/pull/847/files#diff-701133a10ee7bdd5365c112da105d17aadfa7e3cd51c999e80c2d667f2de6891R31

Which is not a simple rename:

I stopped digging at this point so am not entirely sure how large the chain of changes will be.

[Shazwazza]

Thanks @jemayn, I suppose I just meant, we need to recompile (fix breaking changes) for v4beta with the latest Lucene beta, and then ship a new release :)

I'll try to take a look tomorrow.