Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential memory leak #148

Open
Roshyo opened this issue Sep 1, 2021 · 0 comments
Open

Potential memory leak #148

Roshyo opened this issue Sep 1, 2021 · 0 comments

Comments

@Roshyo
Copy link
Contributor

Roshyo commented Sep 1, 2021

In Setono\SyliusGiftCardPlugin\Controller\Action\GiftCardBalanceAction controller (and same in API when merged to master), we have a performance issue regarding huge amount of GiftCards due to this code block:

$giftCardBalanceCollection = GiftCardBalanceCollection::createFromGiftCards(
    $this->giftCardRepository->findEnabled()
);

We should come up with a solution to avoid that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant