Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create filesystem abstraction #5

Open
loevgaard opened this issue Sep 10, 2019 · 3 comments
Open

Create filesystem abstraction #5

loevgaard opened this issue Sep 10, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@loevgaard
Copy link
Member

Instead of depending directly on flysystem a filesystem abstraction could be made (with adapters for flysystem, gaufrette and others).

Besides allowing different filesystem abstractions it will also allow us to have other methods in the filesystem interface, i.e.: function isDeeplinkingAvailable(): bool and function getDeeplink(): string. The latter method would generate a direct link to the feed instead of having to go through the ShowFeedAction.

@loevgaard loevgaard added the enhancement New feature or request label Sep 10, 2019
@loevgaard loevgaard self-assigned this Sep 10, 2019
@gabiudrescu
Copy link

isn't flysystem an abstraction already for filesystems?

isn't it a bit too much to have an abstraction of abstractions?

@loevgaard
Copy link
Member Author

isn't flysystem an abstraction already for filesystems?

Yes :D

However, making an abstraction doesn't mean you have to use another abstraction to utilize it. You can also create your own concrete implementation. Anyway, do you have an idea to the problem with deeplinking that could solve it without introducing another filesystem abstraction?

@hdasdoria
Copy link

Hi! I know it's an old subject, but I'd like to know if there's any update about it.

Knowing the fact Sylius uses KnpGaufrette, it forces us to use 2 different filesystem configurations. With complex ecosystems (cloud storage for assets/static files, multi-pod environment...) it's starting to become a bit painful to have it all working (or we have to override the services using flysystem).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants