Fix bug is stats calc.

Layoric · Layoric · commit f4933d9bd5ea · 2024-04-03T17:21:36.000+11:00
diff --git a/MyApp.ServiceInterface/LeaderboardServices.cs b/MyApp.ServiceInterface/LeaderboardServices.cs
@@ -41,9 +41,13 @@ public async Task<object> Any(CalculateLeaderBoard request)
     private CalculateLeaderboardResponse CalculateLeaderboardResponse(List<StatTotals> statTotals, List<StatTotals> statsByUser, List<StatTotals> answers)
     {
         var statQuestions = statTotals.Where(x => !x.Id.Contains('-')).ToList();
+        
+        // There might not be answers to some questions which we want to exclude from the win rate
+        statQuestions = statQuestions.Where(x => answers.Any(y => y.PostId == x.PostId)).ToList();
 
         var overallWinRates = statsByUser.GroupBy(x => x.Id).Select(y =>
         {
+            // sum all the wins for this user
             var res = new LeaderBoardWinRate
             {
                 Id = y.Key,

Original file line number	Diff line number	Diff line change
`@@ -41,9 +41,13 @@ public async Task<object> Any(CalculateLeaderBoard request)`
`41`	`41`	`private CalculateLeaderboardResponse CalculateLeaderboardResponse(List<StatTotals> statTotals, List<StatTotals> statsByUser, List<StatTotals> answers)`
`42`	`42`	`{`
`43`	`43`	`var statQuestions = statTotals.Where(x => !x.Id.Contains('-')).ToList();`
	`44`	`+`
	`45`	`+ // There might not be answers to some questions which we want to exclude from the win rate`
	`46`	`+ statQuestions = statQuestions.Where(x => answers.Any(y => y.PostId == x.PostId)).ToList();`
`44`	`47`
`45`	`48`	`var overallWinRates = statsByUser.GroupBy(x => x.Id).Select(y =>`
`46`	`49`	`{`
	`50`	`+ // sum all the wins for this user`
`47`	`51`	`var res = new LeaderBoardWinRate`
`48`	`52`	`{`
`49`	`53`	`Id = y.Key,`