From edb78b2dbfb33b38c1745b125fbc82e6ddf603bb Mon Sep 17 00:00:00 2001 From: werzet <10843461+Werzet@users.noreply.github.com> Date: Sun, 17 Nov 2024 20:42:52 +1000 Subject: [PATCH 1/9] add perms --- .github/workflows/labeler-changes.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/labeler-changes.yml b/.github/workflows/labeler-changes.yml index e7d8fc45e16d..aa4ce0554e8d 100644 --- a/.github/workflows/labeler-changes.yml +++ b/.github/workflows/labeler-changes.yml @@ -7,6 +7,7 @@ on: jobs: update_label: permissions: + contents: write pull-requests: write if: github.event.review.state == 'changes_requested' runs-on: ubuntu-latest From 3a8fe5ca0187386136e9ae2e0cf55997fa9f26e6 Mon Sep 17 00:00:00 2001 From: werzet <10843461+Werzet@users.noreply.github.com> Date: Sun, 17 Nov 2024 20:56:52 +1000 Subject: [PATCH 2/9] try with direct token --- .github/workflows/labeler-approve.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/labeler-approve.yml b/.github/workflows/labeler-approve.yml index c3a2a25ddf89..f16f79e8d3dc 100644 --- a/.github/workflows/labeler-approve.yml +++ b/.github/workflows/labeler-approve.yml @@ -15,6 +15,7 @@ jobs: steps: - uses: actions-ecosystem/action-remove-labels@v1 with: + github_token: ${{ github.token }} labels: | Status: Needs Review Status: Awaiting Changes From 512e5d8ad14e5c6bc7152894928f690c8363f0eb Mon Sep 17 00:00:00 2001 From: werzet <10843461+Werzet@users.noreply.github.com> Date: Sun, 17 Nov 2024 20:59:31 +1000 Subject: [PATCH 3/9] remove token --- .github/workflows/labeler-approve.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/labeler-approve.yml b/.github/workflows/labeler-approve.yml index f16f79e8d3dc..c3a2a25ddf89 100644 --- a/.github/workflows/labeler-approve.yml +++ b/.github/workflows/labeler-approve.yml @@ -15,7 +15,6 @@ jobs: steps: - uses: actions-ecosystem/action-remove-labels@v1 with: - github_token: ${{ github.token }} labels: | Status: Needs Review Status: Awaiting Changes From a84459c816747a307d1c04deb455600908672251 Mon Sep 17 00:00:00 2001 From: werzet <10843461+Werzet@users.noreply.github.com> Date: Sun, 17 Nov 2024 21:06:32 +1000 Subject: [PATCH 4/9] remove perms --- .github/workflows/labeler-approve.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/labeler-approve.yml b/.github/workflows/labeler-approve.yml index c3a2a25ddf89..74d82a42b823 100644 --- a/.github/workflows/labeler-approve.yml +++ b/.github/workflows/labeler-approve.yml @@ -6,10 +6,6 @@ on: jobs: remove_label: - permissions: - contents: write - pull-requests: write - statuses: write if: github.event.review.state == 'approved' runs-on: ubuntu-latest steps: From fa373e6458c825d00d6e971c083f031e2e49e339 Mon Sep 17 00:00:00 2001 From: werzet <10843461+Werzet@users.noreply.github.com> Date: Sun, 17 Nov 2024 21:10:11 +1000 Subject: [PATCH 5/9] change type --- .github/workflows/labeler-approve.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/labeler-approve.yml b/.github/workflows/labeler-approve.yml index 74d82a42b823..8ba6e25ab3b5 100644 --- a/.github/workflows/labeler-approve.yml +++ b/.github/workflows/labeler-approve.yml @@ -2,7 +2,7 @@ on: pull_request_review: - types: [submitted] + types: [commet] jobs: remove_label: From 65b15367f9ee80ab20248ce1dcc6e538c2ee0c00 Mon Sep 17 00:00:00 2001 From: werzet <10843461+Werzet@users.noreply.github.com> Date: Sun, 17 Nov 2024 21:13:05 +1000 Subject: [PATCH 6/9] change type --- .github/workflows/labeler-changes.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/labeler-changes.yml b/.github/workflows/labeler-changes.yml index aa4ce0554e8d..dad38ac7e401 100644 --- a/.github/workflows/labeler-changes.yml +++ b/.github/workflows/labeler-changes.yml @@ -2,14 +2,14 @@ on: pull_request_review: - types: [submitted] + types: [comment] jobs: update_label: permissions: contents: write pull-requests: write - if: github.event.review.state == 'changes_requested' + runs-on: ubuntu-latest steps: - uses: actions-ecosystem/action-add-labels@v1 From d09d8100695088c782ac886f708585cc68f09ecd Mon Sep 17 00:00:00 2001 From: UrPrice Date: Tue, 10 Dec 2024 04:59:47 +0300 Subject: [PATCH 7/9] Merge conflict fix --- .github/workflows/labeler-changes.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/labeler-changes.yml b/.github/workflows/labeler-changes.yml index dad38ac7e401..95e8cee34933 100644 --- a/.github/workflows/labeler-changes.yml +++ b/.github/workflows/labeler-changes.yml @@ -2,16 +2,18 @@ on: pull_request_review: - types: [comment] + types: [submitted] jobs: update_label: + if: github.event.review.state == 'changes_requested' + runs-on: ubuntu-latest permissions: - contents: write pull-requests: write - - runs-on: ubuntu-latest + contents: write steps: + - name: Debug + run: echo "${{ toJson(github.event) }}" - uses: actions-ecosystem/action-add-labels@v1 with: labels: "Status: Awaiting Changes" From c947c69d2a4423cc446e341774b9e94eec9027f1 Mon Sep 17 00:00:00 2001 From: UrPrice Date: Tue, 10 Dec 2024 05:12:11 +0300 Subject: [PATCH 8/9] mrc --- .github/workflows/labeler-changes.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/labeler-changes.yml b/.github/workflows/labeler-changes.yml index 95e8cee34933..7626aff72c54 100644 --- a/.github/workflows/labeler-changes.yml +++ b/.github/workflows/labeler-changes.yml @@ -13,7 +13,7 @@ jobs: contents: write steps: - name: Debug - run: echo "${{ toJson(github.event) }}" + run: printf "%s\n" "${{ toJson(github.event)}}" - uses: actions-ecosystem/action-add-labels@v1 with: labels: "Status: Awaiting Changes" From 248293c36ea686b565f17aeb2e740813beadb8e4 Mon Sep 17 00:00:00 2001 From: UrPrice Date: Tue, 10 Dec 2024 05:31:51 +0300 Subject: [PATCH 9/9] mcr2 --- .github/workflows/labeler-changes.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/labeler-changes.yml b/.github/workflows/labeler-changes.yml index 7626aff72c54..d9806a77479b 100644 --- a/.github/workflows/labeler-changes.yml +++ b/.github/workflows/labeler-changes.yml @@ -12,8 +12,6 @@ jobs: pull-requests: write contents: write steps: - - name: Debug - run: printf "%s\n" "${{ toJson(github.event)}}" - uses: actions-ecosystem/action-add-labels@v1 with: labels: "Status: Awaiting Changes"