Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of extract() #7

Open
Wiljami opened this issue Jul 30, 2020 · 2 comments
Open

Remove use of extract() #7

Wiljami opened this issue Jul 30, 2020 · 2 comments

Comments

@Wiljami
Copy link
Member

Wiljami commented Jul 30, 2020

The plugin makes use of extract() function which is problematic as it hides where variables are coming from.

WordPress has it deprecated and is working to remove its use: https://core.trac.wordpress.org/ticket/22400

Should this plugin be rewritten to function without it?

@ottok
Copy link
Contributor

ottok commented Aug 6, 2020 via email

@Wiljami
Copy link
Member Author

Wiljami commented Aug 6, 2020

I agree. From the looks of this project, it never reached a very mature state and hasn't been kept up to date.

Removing plugins that are out of date and unsupported from wp.org would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants