Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase config.yml 'avahi: true' option #116

Open
l3ku opened this issue Oct 18, 2019 · 1 comment
Open

Rephrase config.yml 'avahi: true' option #116

l3ku opened this issue Oct 18, 2019 · 1 comment

Comments

@l3ku
Copy link
Contributor

l3ku commented Oct 18, 2019

The actual meaning of the option is currently to expose the Vagrant box on OS X to the local network via bridge interface:

wordpress/Vagrantfile

Lines 89 to 99 in 54b867d

# Only use avahi if config has this
# development:
# avahi: true
if site_config['development']['avahi'] && has_internet? and is_osx?
# The box uses avahi-daemon to make itself available to local network
config.vm.network "public_network", bridge: [
"en0: Wi-Fi (AirPort)",
"en1: Wi-Fi (AirPort)",
"wlan0"
]
end

As we currently already always use Avahi in the box by default, we should maybe rephrase this option to be more logical, like public: true, bridge: true or something else. We could also consider either dropping this feature or also enable the feature for Linux depending on the actual value this feature currently provides for our customers.

@ottok
Copy link
Contributor

ottok commented Jan 27, 2021

The question is, what would be a better name then? If it is changed, it needs to be coordinated so that the Vagrantfile, config-example.yml in the project template and also scripts inside the Vagrant box all update at the same time, and there needs to be enough documentation in place so those who use the current setting name knows to update their config.yml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants